Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix wildcard-in-the-middle for US-military.xml - #12314

Closed
RReverser wants to merge 1 commit into
EFForg:masterfrom
RReverser:patch-10
Closed

RReverser wants to merge 1 commit into
EFForg:masterfrom
RReverser:patch-10

Conversation

@RReverser

Copy link
Copy Markdown
Contributor

See #4369. Only these subdomains seem to be matched by a regexp.

See EFForg#4369. Only these subdomains seem to be matched by a regexp.
@jeremyn

jeremyn commented Nov 20, 2017 •

Copy link
Copy Markdown
Contributor

How did you find these domains? I tried searching Google but it had no results, and I don't know if that's because there really are no domains matching the pattern usarmy.*.llnwd.net , or if I'm searching incorrectly.

@jeremyn jeremyn self-assigned this Nov 20, 2017
@RReverser

RReverser commented Nov 20, 2017 •

Copy link
Copy Markdown
Contributor Author

Just check the regex on line 56 :) TL;DR - it's anyway only two domains this target was applied to.

@jeremyn

jeremyn commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

Oh okay, thanks. I've added another item to the checklist to delete the rule, too.

@jeremyn

jeremyn commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

@RReverser Can we move forward on this one?

@jeremyn jeremyn mentioned this pull request Dec 18, 2017
@jeremyn

jeremyn commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

I'm closing this pull request in favor of my pull request #14011.

@jeremyn jeremyn closed this Dec 18, 2017
@jeremyn jeremyn removed their assignment Dec 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants